Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anthropic: improve handling of multipart tool responses #1011

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

anthropic: improve handling of multipart tool responses #1011

wants to merge 1 commit into from

Conversation

lonelycode
Copy link

fixes #1010

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

tmc
tmc reviewed Sep 13, 2024
View reviewed changes
Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you share a test or example showing an issue.

I'm open to getting in a fix here but we really need more robust testing here.

@tmc tmc changed the title fixes #1010 (anthropic not handling multipart tool responses) anthropic: improve handling of multipart tool responses Sep 13, 2024
@bloeys
Copy link

bloeys commented Nov 17, 2024

Just wanted to note that while this (and related commits by @lonelycode) do solve the problem and give a proper tool response, I notice tool calls are not streamed. This can be extremely helpful when tool arguments are very long.

We can either include a new 'WithToolStreamingFunc' or send tool chunks into the existing streaming function with perhaps some prefix (risk of false-positive), or just update the existing function signature (breaking change, but should be fine as we are still v0.x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmc tmc tmc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

anthropic driver doesn't handle multi-part tool results
3 participants
@lonelycode @bloeys @tmc