Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[weaviate store] Similarity search returns an error if there are no docs in the response #1065

Open
mdelapenya opened this issue Nov 13, 2024 · 0 comments

Comments

@mdelapenya
Copy link
Contributor

I've playing around with different stores and I noticed the weaviate implementation is behaving differently as others, returning an specific err in the case the datastore returns zero relevant docs.

I checked the other store implementations, and for them it's fine to return an slice of zero elements:

I'd see convenient that all stores define the same expectations.

In the case this is of interest, I can work on the fix.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant