You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've playing around with different stores and I noticed the weaviate implementation is behaving differently as others, returning an specific err in the case the datastore returns zero relevant docs.
I checked the other store implementations, and for them it's fine to return an slice of zero elements:
I've playing around with different stores and I noticed the weaviate implementation is behaving differently as others, returning an specific
err
in the case the datastore returns zero relevant docs.I checked the other store implementations, and for them it's fine to return an slice of zero elements:
langchaingo/vectorstores/weaviate/weaviate.go
Line 232 in 238d1c7
langchaingo/vectorstores/qdrant/rest.go
Line 104 in 238d1c7
langchaingo/vectorstores/chroma/chroma.go
Line 152 in 238d1c7
langchaingo/vectorstores/pgvector/pgvector.go
Line 342 in 238d1c7
langchaingo/vectorstores/milvus/milvus.go
Line 261 in 238d1c7
I'd see convenient that all stores define the same expectations.
In the case this is of interest, I can work on the fix.
Thanks!
The text was updated successfully, but these errors were encountered: