Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agents: Fix agents package API #463

Open
4 tasks
tmc opened this issue Dec 29, 2023 · 3 comments
Open
4 tasks

agents: Fix agents package API #463

tmc opened this issue Dec 29, 2023 · 3 comments

Comments

@tmc
Copy link
Owner

tmc commented Dec 29, 2023

A few improvements to the agents package include:

  • Executor -> *Executor
  • Deprecate Initialize
  • Rename CreationOption+CreationOptions to Option+Options
  • Move agent-specific types/implementations to subpackages
@lujingxuansc
Copy link

I would appreciate it if this PR could be assigned to me.

@haochunchang
Copy link
Contributor

Hi, I would like to ask what does "Rename CreationOption+CreationOptions to Option+Options” mean?
Does it means changing CreationOption type into Option?
For example:

// Changing this
type CreationOption func(*CreationOptions)
// into this
type Option func(*Options)

@tmc
Copy link
Owner Author

tmc commented Jan 26, 2024

Hi, I would like to ask what does "Rename CreationOption+CreationOptions to Option+Options” mean? Does it means changing CreationOption type into Option? For example:

// Changing this
type CreationOption func(*CreationOptions)
// into this
type Option func(*Options)

Yes that's what I meant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants