Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// @ts-check
is not a good way to check js filesThere are code changes in this PR. Most of them are to satisfy lint and are no functionally different. However, a few are bug fixes that showed themselves to be bugs via linting.
I like this ruleset and use it all over the place (also happens to be what we use in discord.js) but if there is code styling that you do not like, I am happy to change those rules before merging this. There are a couple of places where I disabled rules for a chunk of lines because it was obvious that they were split up on purpose for readability and the "more readable" linted version was not actually.
P.s. Sorry about the diff, not much to do about that, and better to do it now than later.