Ruby 2.5 support #17
Open
Ruby 2.5 support #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjordan
added a commit
to code-dot-org/code-dot-org
that referenced
this pull request
Feb 15, 2018
fork gctools gem, tmm1/gctools#17
Open
|
@wjordan Hey, have you been using this patch in production with Ruby 2.5? Have you noticed any performance benefits with it? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains what I think is a minimal set of changes necessary to compile and run this extension as-is on Ruby 2.4 and 2.5.
Fixes #16.
The one part I'm a little uneasy about is that the
GC.stat(:heap_swept_slots)counter was removed in Ruby 2.4 due to some internal refactoring of the mark-and-sweep algorithm, and I'm not sure if replacing this counter with0heap_marked_slots] in the calculation ofallocation_limitwill impact this behavior significantly- I don't fully understand the Ruby GC-implementation internals to be confident in that,or even whether this will work or be useful in Ruby 2.5 at all for that matter[edit: I've run this PR in production for several months now, and it has been useful].In any case this is a starting point I plan to use for profiling my own web-application through a Ruby upgrade, and I'm sharing it here in case others might find it useful as well.