Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(doc-storage): impl blob storages #8539

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

forehalo
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Oct 17, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

forehalo commented Oct 17, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Oct 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8042850. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 51.76056% with 137 lines in your changes missing coverage. Please review.

Project coverage is 70.00%. Comparing base (23c9b50) to head (8042850).
Report is 3 commits behind head on 61/storage-layer.

Files with missing lines Patch % Lines
...s/backend/server/src/core/storage/wrappers/blob.ts 52.11% 68 Missing ⚠️
packages/backend/server/src/core/sync/gateway.ts 28.81% 42 Missing ⚠️
...ckend/server/src/core/workspaces/resolvers/blob.ts 54.00% 23 Missing ⚠️
packages/backend/server/src/core/quota/resolver.ts 90.90% 2 Missing ⚠️
packages/backend/server/src/core/quota/storage.ts 66.66% 1 Missing ⚠️
...backend/server/src/plugins/storage/providers/s3.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           61/storage-layer    #8539      +/-   ##
====================================================
- Coverage             70.14%   70.00%   -0.15%     
====================================================
  Files                   536      536              
  Lines                 33678    33817     +139     
  Branches               3021     3030       +9     
====================================================
+ Hits                  23624    23674      +50     
- Misses                 9699     9790      +91     
+ Partials                355      353       -2     
Flag Coverage Δ
server-test 76.84% <51.76%> (-0.22%) ⬇️
unittest 45.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forehalo forehalo marked this pull request as draft October 18, 2024 06:03
@github-actions github-actions bot added the docs Improvements or additions to documentation label Oct 22, 2024
@github-actions github-actions bot added test Related to test cases app:core labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:server docs Improvements or additions to documentation mod:native rust test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant