Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isTogglURL failing for empty strings #1944

Closed
toggl-button-bot opened this issue Apr 16, 2021 · 1 comment · Fixed by #1947
Closed

isTogglURL failing for empty strings #1944

toggl-button-bot opened this issue Apr 16, 2021 · 1 comment · Fixed by #1947
Assignees
@Phenome
Labels
1.69.7 bug released

Comments

@toggl-button-bot
Copy link
Collaborator

Error in Track Browser Extension (Toggl Button)

TypeError in /_generated_background_page.html
Failed to construct 'URL': Invalid URL

View on Bugsnag

Stacktrace

dist/scripts/webpack:/scripts/lib/utils.ts:43 - isTogglURL
dist/scripts/webpack:/scripts/background.js:2172 - TogglButton

View full stacktrace

Created by Henrique Pinheiro via Bugsnag
@Phenome Phenome self-assigned this Apr 16, 2021
Phenome added a commit that referenced this issue Apr 16, 2021
@Phenome
fix(url): Treat empty URLs
ae7b580 
Closes #1944
Phenome added a commit that referenced this issue Apr 16, 2021
@Phenome
fix(url): Treat empty URLs
f5398dd 
Closes #1944
@Phenome Phenome mentioned this issue Apr 16, 2021
Closed
Phenome added a commit that referenced this issue Apr 16, 2021
@Phenome
fix(url): Treat empty URLs
dacc1eb 
Closes #1944
@Phenome Phenome mentioned this issue Apr 20, 2021
Merged
Phenome added a commit that referenced this issue Apr 20, 2021
@Phenome
fix(url): Treat empty URLs
ecaa634 
Closes #1944
toggl-button-bot added a commit that referenced this issue Apr 20, 2021
@toggl-button-bot
chore(release): 1.69.8 [skip ci]
ce2d24a 
## [1.69.8](1.69.7...1.69.8) (2021-04-20)

### Bug Fixes

* **bugsnag:** 5de0b5e4f79de300196e4f1b ([f3f4681](f3f4681))
* **bugsnag:** Fix "Missing host permission for the tab" ([9614b55](9614b55))
* **bugsnag:** Fixes 6079b3d1d7635b0008abd5c3 ([8fb27e4](8fb27e4))
* **url:** Treat empty URLs ([ecaa634](ecaa634)), closes [#1944](#1944)
@toggl-button-bot
Copy link
Collaborator Author

🎉 This issue has been resolved in version 1.69.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Phenome Phenome

Labels
1.69.7 bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1944/bugsnag fixes toggl/track-extension
fix(url): Treat empty URLs toggl/track-extension
2 participants
@Phenome @toggl-button-bot