Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zendesk): Include ticket id in description #1996

Merged
merged 1 commit into from
Nov 23, 2021
Merged

fix(zendesk): Include ticket id in description #1996

merged 1 commit into from
Nov 23, 2021

Conversation

rylek90
Copy link
Contributor

@rylek90 rylek90 commented Aug 11, 2021

🌟 What does this PR do?

Handles ticket id in new Zendesk UI

🐛 Recommendations for testing

  • Go to Zendesk (new UI, so might just sign up with new trial)
  • Verify if Ticket ID is present in description

image

📝 Links to relevant issues or information

Closes #1995

@rylek90 rylek90 requested review from Phenome and nunofmn August 11, 2021 11:57
@rylek90 rylek90 self-assigned this Aug 11, 2021
nunofmn
nunofmn approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@nunofmn nunofmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 🚀

@nunofmn nunofmn merged commit c28f1f3 into master Nov 23, 2021
@nunofmn nunofmn deleted the 1995/zendesk-id branch November 23, 2021 14:50
toggl-button-bot added a commit that referenced this pull request Nov 23, 2021
@toggl-button-bot
chore(release): 1.72.2 [skip ci]
427dbbd 
## [1.72.2](1.72.1...1.72.2) (2021-11-23)

### Bug Fixes

* **github:** Fix projects page numElem not passing ([#1998](#1998)) ([36d68cc](36d68cc))
* **zendesk:** Include ticket id in description ([#1996](#1996)) ([c28f1f3](c28f1f3)), closes [#1995](#1995)
@toggl-button-bot
Copy link
Collaborator

🎉 This PR is included in version 1.72.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunofmn nunofmn nunofmn approved these changes

@Phenome Phenome Awaiting requested review from Phenome

Assignees

@rylek90 rylek90

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zendesk integration is not pulling zendesk ticker number
3 participants
@rylek90 @toggl-button-bot @nunofmn