fix(github): Fix projects page numElem not passing #1998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update the selector for numElem so it passes to toggl button
nunofmn
approved these changes
Nov 23, 2021
toggl-button-bot
added a commit
that referenced
this pull request
Nov 23, 2021
|
🎉 This PR is included in version 1.72.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first PR in this repo, I read the Contributing.md but let me know if I missed anything!
🌟 What does this PR do?
The current plugin doesn't pass the issue or PR number on GitHub projects through to the toggl button on there. It looks like GitHub might have changed the class the plugin was using to select the element.
After the fix the numElem passes, for example below the
#1569is now being passed:🐛 Recommendations for testing
Load the plugin in chrome and firefox, then go to a project page (e.g. a project on this repo) and click a ticket and click the "Start Timer". It should now show the
numElembeing passed.📝 Links to relevant issues or information