Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment step cuts bp off of some sequences #27

Open
susanrkennedy opened this issue Feb 14, 2022 · 1 comment
Open

Alignment step cuts bp off of some sequences #27

susanrkennedy opened this issue Feb 14, 2022 · 1 comment

Comments

@susanrkennedy
Copy link

The Align Sequences button in the Sequence Data Tool cuts bp off of the end of some sequences in the alignment, and shifts reading frame by inserting gaps:
align_comparison
This does not happen with every dataset I have tried, but consistently happens to some of them.

@tokebe
Copy link
Owner

tokebe commented Mar 5, 2023

Apologies for the long delay to explaining this. This is caused by the trimming step, which occurs after the alignment. The trimming step shifts the reading frame to ensure there are no stop codons, and then trims to ensure the sequences are a multiple of 3 length.

This implementation is rather incomplete, and is currently being re-written to not remove base pairs, instead relying only on adding gaps. The rewrite will fix additional issues and hopefully make the whole thing a bit more reliable and more clear in the steps it's taking.

I'll mark the issue closed when the rewrite is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants