-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Solaris operating system support #1724
Conversation
@Thomasdezeeuw can you please look here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm that it now works without RUSTFLAGS
?
Also could you add Solaris to
Line 155 in e80c3b2
target: ["armv7-sony-vita-newlibeabihf"] |
3d076d6
to
69ce07b
Compare
I can confirm that |
@psumbera can you fix the CI? |
Not really sure... I can reproduce it on Linux. But now I don't know what to do... Why it's failing for |
Maybe try (I don't have my regular dev setup atm, so can't test) diff --git a/src/sys/unix/mod.rs b/src/sys/unix/mod.rs
index 7804236..28e0bea 100644
--- a/src/sys/unix/mod.rs
+++ b/src/sys/unix/mod.rs
@@ -17,7 +17,9 @@ cfg_os_poll! {
mod selector;
pub(crate) use self::selector::{event, Event, Events, Selector};
+ #[cfg(feature = "os-ext")]
mod sourcefd;
+ #[cfg(feature = "os-ext")]
pub use self::sourcefd::SourceFd;
mod waker; |
Now I'm getting (with
|
932b27a
to
69ce07b
Compare
I think this might be known Rust issue: rust-lang/rust#115966 . Adding Though not sure what is status of CI now? |
I see now new results. Thank you! The only failure is |
@Thomasdezeeuw can this be merged now please? |
src/sys/mod.rs
Outdated
@@ -54,6 +54,7 @@ cfg_os_poll! { | |||
#[cfg(unix)] | |||
cfg_os_poll! { | |||
mod unix; | |||
#[warn(unused_imports)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't make sense. Did you mean to disable the lint? That would be the following, but really we shouldn't need it at all.
#[warn(unused_imports)] | |
#[allow(unused_imports)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, #[allow(unused_imports)]
does make sense. Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Thomasdezeeuw can you please merge it now?
…solaris --no-default-features --features net (and os-poll)
ad3b65c
to
d70e46e
Compare
Thanks @psumbera |
No description provided.