Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add msg_control access for UdpSocket::recvmsg. #275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Icelk
Copy link
Contributor

@Icelk Icelk commented Jul 20, 2023

Closes #274.
The parameter is optional, so this is an opt-in change. However, it changes the public facing API.
I can add another public facing function with this functionality while keeping the old API, if you'd like :)

@Icelk Icelk force-pushed the recvmsg-msg_control branch from 6ddd0e9 to 840cf7d Compare July 20, 2023 23:16
@Icelk
Copy link
Contributor Author

Icelk commented Sep 14, 2023

My implementation of HTTP/3 (with interop between tokio-uring and quinn) currently blocks on this. Would it be possible to get this merged?

When is the next version/patch expected to be released? As I mentioned in my initial comment, adding another function would keep the API from breaking.

@Icelk
Copy link
Contributor Author

Icelk commented Sep 14, 2023

BTW, the CI isn't broken because of me 🫣

@Icelk Icelk force-pushed the recvmsg-msg_control branch from 840cf7d to 7b82607 Compare February 4, 2024 21:29
OneOfOne added a commit to ooo-rs/tokio-uring-ooo that referenced this pull request Apr 13, 2024
@Icelk
Copy link
Contributor Author

Icelk commented May 25, 2024

Hi!
Is there any chance this can be merged?

Thanks,
Icelk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return msghdr from recvmsg
1 participant