Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example app #13

Open
tom-sherman opened this issue Jan 10, 2022 · 3 comments
Open

Example app #13

tom-sherman opened this issue Jan 10, 2022 · 3 comments
Labels
good first issue Good for newcomers

Comments

@tom-sherman
Copy link
Owner

Add an example app in this repo to serve as a test bed for type checking and integration tests (likely needs cypress)

@tom-sherman tom-sherman added the good first issue Good for newcomers label Jan 10, 2022
@drewschrauf
Copy link
Contributor

I was planning on doing a port of the Jokes app as a combined sanity check of the bindings and a reference for future travellers. It doesn't cover 100% of the Remix API surface but I think it would serve as good documentation. We may want to add a "kitchen sink" app to this repo for coverage.

What do you reckon, should I do the Jokes port as a PR against this repo or a separate repo using the template as a base?

@tom-sherman
Copy link
Owner Author

tom-sherman commented Jan 11, 2022

I think it would be worth including it in this repo as a form of integration tests and to serve as an example 👍

If you do work on this, don't worry too much about writing any tests - we can do that later on.

@drewschrauf
Copy link
Contributor

Thought you might be interested in seeing the progress. I've got it up on a fork here.

I've added some bindings for session stuff and a few alternative bindings for variadic functions in Remix. There's a tonne of them. There's also quite a few optional return types (like, loader functions can return raw data or a Response).

I'm not sure what the general policy should be for this kind of thing: provide alternative bindings or only support the most permissive versions? Similarly, should we be aiming for zero-cost bindings everywhere or wrapping some of these variadic functions in Rescript functions with optional labelled arguments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants