Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Scrolling on Playlist/Chapters Menus conflicts with Wheel Commands on input.conf #495

Closed
Cananbolt opened this issue Apr 3, 2023 · 13 comments

Comments

@Cananbolt
Copy link

To explain, I have the following keybinds in input.conf,

WHEEL_UP add volume -2
WHEEL_Down add volume 2

Whenever I scroll through my files in a playlist or chapter in UOSC menus, it would conflict with the keybind above, and it would suddenly activate the WHEEL Keybinds above, causing my sound to increase or decrease, instead of scrolling through the menus.

@tomasklaen
Copy link
Owner

There has been a recent change in handling these events. Are you on master or latest release? Because I can't replicate on either.

@Cananbolt
Copy link
Author

There has been a recent change in handling these events. Are you on master or latest release? Because I can't replicate on either.

I completely updated UOSC 4 days ago, following the plethora of updates.

@tomasklaen
Copy link
Owner

Last commit was yesterday. You might have updated while I was in the middle of reworking event handling. Try updating to current master.

But again, I can't replicate, so if the issue still persist, maybe recording a video would tells us more? Because I can't see or think of any issues in code that would cause this.

@Cananbolt
Copy link
Author

I went ahead and updated the uosc.lua, however, the problem was still there.

Here is a video:
2023-04-03 10-22-59_00-00-9.033-00-00-38.633-[00.00.000-00.29.738]-audio.webm

@christoph-heinrich
Copy link
Contributor

Can't reproduce 😐

@tomasklaen
Copy link
Owner

Me neither, no matter how fast I scroll or how small I make the menu items.

Can you try disabling all other scripts and see if it still persists?

@WhoMI7
Copy link

WhoMI7 commented Apr 3, 2023

I had same issue , just more problematic.
I couldn't scroll randomly while in any menu uosc or any other.
In my case this was because of some/outdated scripts. I had to update/delete a lot of scripts to make the issue go away.

Maybe try updating the scripts manually, NOT using mpv manager to update.
If there aren't any updates within a long time period (1 year or more) consider deleting the script.

This method worked for me, might not work for you so take it with a grain of salt.
Also backup your config directory before trying aforementioned tips.

@tomasklaen
Copy link
Owner

uosc asks mpv to take over the wheel events when it needs them (you hover over the menu). If you keep hovering, and some other script asks for wheel events, it'll overwrite us, and uosc will stop handling them. We can't do much about that. I don't think we can even detect if something like that happens.

@christoph-heinrich
Copy link
Contributor

Even if it gets overwritten by some other script, we should get events again once they disable their binding. Instead it does the thing from input.conf like nothing is bound.

@Cananbolt
Copy link
Author

So, I got rid of every script, besides UOSC and the problem still continued. I also got rid of my script modules, and nothing.

Edit: Found the issue. It was uosc.conf. That was the only thing I haven't updated. I'll install the latest one and put my configs back and see if the problem still happens.

@Cananbolt
Copy link
Author

Cananbolt commented Apr 3, 2023

Found the problem, it is autohide=yes.
Once I changed it to autohide=no it worked again. However, I would like autohide to be turned on.

@tomasklaen
Copy link
Owner

Yeah that was a uosc bug. Thx for catching it. Should be fixed now.

@Cananbolt
Copy link
Author

Cananbolt commented Apr 3, 2023

Thank you, I went ahead and tested it and it works! You're welcome, I'm glad I was able to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants