Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(todos): add ngPlural todos filter description, fixes #362 #365

Merged
merged 2 commits into from
Oct 4, 2018
Merged

fix(todos): add ngPlural todos filter description, fixes #362 #365

merged 2 commits into from
Oct 4, 2018

Conversation

erhise
Copy link
Contributor

@erhise erhise commented Oct 1, 2018

What:

Added use case of ngPlural directive usage in todos filter template and added translations.

Issue number: #362

timdeschryver
timdeschryver previously approved these changes Oct 2, 2018
View reviewed changes
Copy link
Collaborator

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @erhise

@timdeschryver timdeschryver dismissed their stale review October 2, 2018 17:09

I noticed something

timdeschryver
timdeschryver requested changes Oct 2, 2018
View reviewed changes
Copy link
Collaborator

@timdeschryver timdeschryver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also change the todos text to Displaying one todo?

image

timdeschryver
timdeschryver approved these changes Oct 3, 2018
View reviewed changes
Copy link
Collaborator

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timdeschryver timdeschryver merged commit 2b001ee into tomastrajan:master Oct 4, 2018
@timdeschryver
Copy link
Collaborator

Thanks @erhise !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erhise @timdeschryver