GB 2.0 - Toolbar - missing align / justffy / float button

[diggeddy]

Description

The toolbar button for text-alignment and image floats are missing from GB 2.0 blocks
For reference these are the the 1.0 toolbar buttons:

[diggeddy]

Float options should really have an option in Styles > Layout

[iansvo]

@tomusborne Do you hate the idea of just...using the same thing? It seems like this was working previously.

@diggeddy Is there an alternative implementation to the previous one that makes sense?

[diggeddy]

A better implementation would be to include Floats as a property in the style tab.
We can leave the toolbar option out, as that would suggest the chosen option "will" work on the chosen block. When that is not necessary the case eg. text-alignment on the figure vs img ....

[tomusborne]

I've added text align to the Container and Text blocks, as well as wide/full align support to the Container block. It should be easy to add these to other blocks as well if we want (although I hope we don't have to add wide/full support to any others lol).

I reverted my changes to add float to the image block. Using float was causing some issues in the editor that were tricky (but not impossible) to figure out. However, there's a bigger issue (that @diggeddy mentioned above) of what happens when you float an image inside of a caption. Really, you should be floating the surrounding block instead of the image. Not sure how we want to approach that.

a) We add the float alignment to the Figure and remove from the image if it has a figure.
b) We check if a figure exists when we use the float options in the image, and target that block to set the floats instead of the image.

[iansvo]

My only concern is that someone may want to use an image container that isn't a figure. So we ideally need some way to indicate the wrapper is related to the image.

I would strongly caution against making assumptions about markup structure that we don't actually enforce.

[diggeddy]

Aside from issues within the editor ... can we just add a Float style to the inspector controls.
Avoid adding logic for things like figure or other wrappers as the user can apply them directly if need be.
We can revisit the UX headaches at a later date, perhaps using patterns

[tomusborne]

Floating in the editor can cause some issues without additional logic (weird z-index things), but I think we can go ahead and do it. I'm assuming we'd need a float and clear option?

[diggeddy]

I'm assuming we'd need a float and clear option?

Yeah we need both. We already display: flow-root so thats in place.