2.0a Controls visibility filter resets too often and feels slow to use

[Kovas]

Unlike the search field, the visibility filter is reset every time the "All Devices" breakpoint is switched or the block is changed.

Additionally, the dropdown feels somewhat sluggish, possibly due to the issue mentioned above. It might be more efficient to use two icons functioning as checkboxes, allowing for faster switching and the ability to combine both filters.

[tomusborne]

Thanks, @Kovas!

This was also mentioned here: https://generatepress.com/generateblocks-2-0-a-new-era/#comment-907410

We should consider storing the filter type in the URL like we do the search params @iansvo.

[iansvo]

@Kovas Just an FYI, the two filter types are not compatible with each other. One of them filters controls that aren't set on the block or global style, the other hides anything that is set and only shows inherited values (i.e. values that aren't set but come from elsewhere).

My latest PR refactors the filters to use the URL search params just like search, which should be better here.

[Kovas]

@iansvo, my reasoning for combining filters is that it simplifies jumping between breakpoints and editing set values quickly.

For example, take the inner container: it has max-width and margins defined at the "All devices" breakpoint. Since filters can't be combined, switching between breakpoints becomes tedious, because one breakpoint has set values, while others show inherited values. Even worse, when editing inherited values, they immediately become set values and vanish from the inherited view, disrupting the flow mid-edit.

[tomusborne]

Re-opening this, as the merged PR only addresses one of the issues.

[iansvo]

My latest PR adds support for multiple filters