Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 Dynamic Tag - {{featured_image}} reconfigure the modal settings. #1546

Open
diggeddy opened this issue Nov 29, 2024 · 1 comment
Open
Assignees
Labels
Dynamic Tags feature Features, refactoring, enhancements, improvements Low Effort

Comments

@diggeddy
Copy link
Collaborator

Description

The modal settings always shows the Image Size option even if the key is neither the URL or ID.

Screenshot 2024-11-29 at 17 51 59

Which means a tag like this exists unless you forcibly clear the image size:

{{featured_image size:medium_large|key:caption}}

Not also the syntax feels incorrect as for most tags the key comes before the other options.

We should swap the key and size field and make the size conditionally display if URL or ID is selected.

Screenshot 2024-11-29 at 17 56 56
@diggeddy diggeddy added the triage Awaiting review label Nov 29, 2024
@iansvo
Copy link
Collaborator

iansvo commented Nov 29, 2024

I'll have a look at this. UX wise I think it makes sense to do better here, but currently these controls are not aware of each other so they just always show up. Maybe there's a smarter way I can do this, I'll noodle on it some.

@iansvo iansvo added feature Features, refactoring, enhancements, improvements Low Effort Dynamic Tags and removed triage Awaiting review labels Dec 3, 2024
@iansvo iansvo self-assigned this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dynamic Tags feature Features, refactoring, enhancements, improvements Low Effort
Projects
None yet
Development

No branches or pull requests

2 participants