Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting minimum and maximum values with commas AND dollar signs? #193

Closed
makeitaboldmove opened this issue Jan 30, 2016 · 4 comments
Closed

Comments

@makeitaboldmove
Copy link

Would love to see an option that allows the minimum and value options to be rendered with a currency format.

@makeitaboldmove makeitaboldmove changed the title Formatting minimum and maximum values with dollar signs and commas Formatting minimum and maximum values with commas AND dollar signs? Jan 30, 2016
@toorshia
Copy link
Owner

Yeah, that makes sense. Will implement it :)

@lucasrosa90
Copy link
Contributor

Instead of just currency, I guess is better implement a label to min and max value.

@makeitaboldmove
Copy link
Author

@lucasrosa90 For now I've customized the library to add the dollar sign but you're right. Prepend and append options for values make sense that way it's not limited to currencies.

@toorshia Thoughts?

@toorshia
Copy link
Owner

toorshia commented Feb 2, 2016

I think the best option would be to provide custom text renderer function for all texts (min, max, value, label...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants