from isHexNumber to isHexColor #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 14, 2020 23:08
Giving a plain hex number is not good for a color string, allow to give a #aabbcc or #fff or #AABBCC or #FFF format string and the font color actually change to something else than to black only. Tested on Windows and Linux various browsers (including wxWidgets WebView).
from isHexNumber to isHexColor
|
LGTM |
|
@Canne 1.3.5 published |
test: day dusk night themes: |
|
Thanks to you! :)
Daniel
… On 15 Jan 2020, at 21:21, Petri Mäkijärvi ***@***.***> wrote:
$ npm ls --depth=0 2>&1 | grep just
+-- ***@***.***
$ npm run debug
test: day dusk night themes:
Looks great! Thanks!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the fix of #342 - now loads OK. However, giving a plain hex number is not good for a color string: Please allow to give a string in #aabbcc or #fff or #AABBCC or #FFF format as parameter and the font color actually changes to something else than to black only as it does in 1.3.4. Tested on Windows and Linux using various browsers (including wxWidgets WebView).