#359 Method Refresh doesn't work with Value zero #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertsLando
requested changes
Feb 15, 2021
dist/justgage.js
Outdated
| @@ -838,8 +838,20 @@ | |||
| var obj = this; | |||
| var displayVal, color; | |||
|
|
|||
| max = max || null; | |||
| min = min || null; | |||
| if (Number.isInteger(max) || Number(max) === max && max % 1 !== 0) { | |||
There was a problem hiding this comment.
I would create a custom function for this check and use something like
function isNumber(n) {
return n !== null && n !== undefined && !isNaN(n)
}
and then use it like:
max = isNumber(max) ? max : null
min = isNumber(min) ? min : null
Added isNumber Function
|
@robertsLando |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated refresh
Added a check if min or max are numbers
When min and max are number, just take over value otherwise min max are set to
null