Add tootctl preview_cards remove
#11320
Conversation
mayaeh
changed the title
tootctl preview-cards removetootctl preview_cards remove
mayaeh
force-pushed
the
feature_tootctl_preview_cards
branch
from
3997dc3 to
a4d4dd5
Compare
It might be possible to add a rate-limit system to Sidekiq jobs. While |
mayaeh
changed the title
tootctl preview_cards removetootctl preview_cards remove
Add exclude case where image_file_name is blank
I think that it isn't happening on my server so far. |
…ys is less than 2 weeks
mayaeh
changed the title
tootctl preview_cards removetootctl preview_cards remove
|
|
||
| if time_ago > 2.weeks.ago | ||
| prompt.say "\n" | ||
| prompt.say('The preview cards less than the past two weeks will not be re-acquired even when needed.') |
There was a problem hiding this comment.
Is this text easy to understand? I do not have any confidence.
There was a problem hiding this comment.
Media remove does not ask for confirmation. Do you think it's necessary here?
There was a problem hiding this comment.
Yes, I think it is necessary.
In preview cards, I think that only those older than 2 weeks will be re-acquired.
https://github.com/tootsuite/mastodon/blob/master/app/services/fetch_link_card_service.rb#L25
On the other hand, I can not find the date limit for re-acquisition of attached media.
Therefore, I think that it is necessary to output a warning if the number of days less than 2 weeks is specified in this command.
* Add `tootctl preview_cards remove` * fix code style * Remove `Scheduler::PreviewCardsCleanupScheduler` file * fix code style again Add exclude case where image_file_name is blank * Added a function to output confirmation if the specified number of days is less than 2 weeks
| option :link, type: :boolean, default: false | ||
| desc 'remove', 'Remove preview cards' | ||
| long_desc <<-DESC | ||
| Removes locally thumbnails for previews. |
There was a problem hiding this comment.
What does locally thumbnails means?
This changes will be change the remove thumbnails of previews from automatic execution by the Sidekiq scheduler to manual execution by the
tootctlcommand.After #11304, object storage’s rate-limit is triggered when
Scheduler::PreviewCardsCleanupScheduleris executed in some object storage environments.This is similar to #8187.
So I made
tootctl preview_cards removecommand referring totootctl media remove.There are multiple
ifstatements.I think that it is not a good writing style.
Please let me know if there is a better way of writing.
TODO