Add paragraph about browser add-ons when encountering some errors #14801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a crash is caused by a NotFoundError exception, add a paragraph to the error page mentioning browser add-ons. Indeed, crashes with NotFoundError are often caused by browser extensions messing with the DOM in ways React.JS can't recover from (e.g. issues mastodon#13325 and mastodon#14731).
|
The resulting message is a little conflicting. "Due to a bug in our code" which then becomes "likely caused by a browser add-on". I suggest that the first paragraph is instead replaced saying: "This page could not be displayed correctly. This error is likely caused by a browser add-on ..." etc. |
ClearlyClaire
force-pushed
the
fixes/error-message-addons
branch
from
45a9f10 to
5f15179
Compare
|
|
ClearlyClaire
force-pushed
the
fixes/error-message-addons
branch
from
5f15179 to
92c0f79
Compare
Gargron
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a crash is caused by a NotFoundError exception, add a paragraph to the error page mentioning browser add-ons.
Indeed, crashes with NotFoundError are often caused by browser extensions messing with the DOM in ways React.JS can't recover from (e.g. issues #13325 and #14731).