Fix unnecessary re-rendering of various components when typing in web UI #15286
+43
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
force-pushed
the
fix-typing-performance-web-ui
branch
from
42eeb93 to
c3beb60
Compare
Comment on lines
-102
to
+108
| this.lastIndex = getIndex(this.context.router.history.location.pathname); | ||
| this.setState({ shouldAnimate: true }); | ||
|
|
||
| const newIndex = getIndex(this.context.router.history.location.pathname); | ||
|
|
||
| if (this.lastIndex !== newIndex) { | ||
| this.lastIndex = newIndex; | ||
| this.setState({ shouldAnimate: true }); | ||
| } |
There was a problem hiding this comment.
I am very unsure about this and haven't seen much benefit to this change.
There was a problem hiding this comment.
Actually, I am ok with this change, although the whole shouldAnimate thing is buggy and I will try to improve it.
ClearlyClaire
approved these changes
Dec 7, 2020
Comment on lines
-102
to
+108
| this.lastIndex = getIndex(this.context.router.history.location.pathname); | ||
| this.setState({ shouldAnimate: true }); | ||
|
|
||
| const newIndex = getIndex(this.context.router.history.location.pathname); | ||
|
|
||
| if (this.lastIndex !== newIndex) { | ||
| this.lastIndex = newIndex; | ||
| this.setState({ shouldAnimate: true }); | ||
| } |
There was a problem hiding this comment.
Actually, I am ok with this change, although the whole shouldAnimate thing is buggy and I will try to improve it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a
componentDidUpdatebeing caused byrouterchange inColumnsArea, a state change was unnecessarily triggered which caused the whole UI to re-render from the top down. Also, the newpictureInPictureattribute caused unnecessary re-renders onStatuscomponents.