Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues: keep-alive, silence when the application fails to start, no specification of the TOML file and what it does, and not clear how to use environment variables #7

Open
JJ opened this issue Oct 22, 2016 · 2 comments

Comments

@JJ
Copy link
Contributor

JJ commented Oct 22, 2016

Well, that's pretty much it. Maybe a bit of more explanation:

  • This error when running

    apm: error: required flag --keep-alive not provided, try --help

  • Specify in documentation what, if anything, is needed to include in the config.toml file

  • Do you always have to start the server?

  • How can I add environment variables? Are they sent through to the running process?

  • Not clear if the program has failed to start. I have to use apm status to find out something.

@MateusDantas
Copy link
Contributor

  • I didn't quite understand the first issue, are you saying that APM is requiring you to set --keep-alive flag?
  • I'm in the process of improving the documentation as we speak. Thanks for the feedback.
  • Yes, you always have to start the server. I will also add it to the documentation.
  • Environment variables are supposed to be sent through the running process. So you can pass new environment variables ENV_1=xxx ENV_2=yyy apm bin ....
  • You are right, I will make it more verbose when trying to run new processes.

Thank you for your feedback. Based on it, I have a couple of suggestions:

  • Let APM start processes through a JSON file. This JSON file will contain a list of processes, with some info, such as environment variables, flags, keep-alive and other data necessary to run it.
  • Make APM more verbose by adding more information when trying to start, stop, restart new processes.

I'm already working on improving the documentation, I will send a PR really soon.

If you have any more suggestions, please let me know.

@MateusDantas
Copy link
Contributor

MateusDantas commented Oct 26, 2016

  • Investigate possible error with keep-alive flag
  • Improve documentation to cover more scenarios PR [documentation] Explain how to start a new application #11
  • Make APM more verbose to the user
  • Add a way to explicitly set environment variables when starting processes
  • Let APM start processes from a structured json file

Maybe the last two tasks can be merged into one, but I will keep them in the meantime so I can have a more clear view of what needs to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants