Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fault resultsScreen.rank value in CTB mode #206

Closed
mas-alone opened this issue Oct 16, 2024 · 3 comments · Fixed by #207
Closed

fault resultsScreen.rank value in CTB mode #206

mas-alone opened this issue Oct 16, 2024 · 3 comments · Fixed by #207

Comments

@mas-alone
Copy link

example osr here:
osr.zip

in the C rank.osk, the true rank is C, but in resultsScreen.rank value is X (S)

in the B rank.osk, the true rank is B, but in resultsScreen.rank value is A

The effect of Katu (Drp Miss) on the ctb mode seems does not appear to have been calculated
B
C
@cyperdark cyperdark linked a pull request Oct 16, 2024 that will close this issue
fix: Pass geki and katu to calculateGrade #207
Merged
@cyperdark
Copy link
Collaborator

Test this build: https://github.com/tosuapp/tosu/actions/runs/11364089631/job/31609395151

@mas-alone
Copy link
Author

Test this build: https://github.com/tosuapp/tosu/actions/runs/11364089631/job/31609395151

Super speed. ty cy! it fixed
QQ20241016-191942

@cyperdark
Copy link
Collaborator

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Pass geki and katu to calculateGrade tosuapp/tosu
2 participants
@cyperdark @mas-alone