Remove some Async & While loops + editor pp
#88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cyperdark
commented
Mar 4, 2024
•
cyperdark
commented
- editor pp
- mostly removed async and while loops
- fixed api v2 fields
- added enums to api v2
- improve errors cover
- fix console.log
- added work around for ingame overlay (better experience)
cyperdark
force-pushed
the
fix/remove-async-while
branch
from
d6b7528 to
12c474b
Compare
cyperdark
force-pushed
the
fix/remove-async-while
branch
from
12c474b to
bd2b104
Compare
KotRikD
requested changes
Mar 7, 2024
cyperdark
force-pushed
the
fix/remove-async-while
branch
from
71552af to
1fee3da
Compare
KotRikD
requested changes
Mar 8, 2024
|
«Отче наш, Иже еси на небесех! Да святится имя Твое, да приидет Царствие Твое, да будет воля Твоя, яко на небеси и на земли. Хлеб наш насущный даждь нам днесь; и остави нам долги наша, якоже и мы оставляем должником нашим; и не введи нас во искушение, но избави нас от лукаваго. Ибо Твое есть Царство и сила и слава во веки. Аминь.» |
KotRikD
pushed a commit
that referenced
this pull request
Mar 10, 2024
* fix: Remove unnecessary async * fix: Open beatmap file only once * fix: Remove some while loops * feat: Add current pp for editor * fix: Remove errors spam, if they aren't constant * fix: Move dependecies to dev * oops )) * oops * fix: Remove useless(?) timeout * feat: Make enabling ingame overlay a little bit better * fix: use boolean for checkGosuConfig * ^$ * remove field * go back * fix: wrong variable * fix: unknown bancho statuses * fix: FIx broken bpm * BREAKING CHANGE: v2 `state` & `progressBar` updated * fix: Updating keyoverlay until process is dead * fix: reuse cached beatmap * fix order * fix: Move detailed errors to debug * update error messages * fix you * Feat: Add process id and patterns scan progress * fix: More detailed errors * fix: cache beatmap for editor * hide updateBindingState too * cleanup * cleanup * fix: return reading interface visible from settingsClassAddr * reduce error spam * to private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.