build: fix GN build for sqlite and nghttp2

PR-URL: nodejs#55529 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Cheng Zhao <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
tpoisseau · Nov 21, 2024 · aa3d5c8 · aa3d5c8
1 parent 6ebdc2c
commit aa3d5c8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/deps/nghttp2/unofficial.gni b/deps/nghttp2/unofficial.gni
@@ -34,6 +34,9 @@ template("nghttp2_gn_build") {
     if (is_clang || !is_win) {
       cflags_c = [
         "-Wno-implicit-fallthrough",
+        # Ref https://github.com/nghttp2/nghttp2/pull/2258
+        # This can be removed when the above PR is ingested.
+        "-Wno-extra-semi",
       ]
     }
   }

diff --git a/deps/sqlite/unofficial.gni b/deps/sqlite/unofficial.gni
@@ -18,8 +18,14 @@ template("sqlite_gn_build") {
     forward_variables_from(invoker, "*")
     public_configs = [ ":sqlite_config" ]
     sources = gypi_values.sqlite_sources
+    cflags_c = [
+      "-Wno-implicit-fallthrough",
+      "-Wno-unreachable-code-return",
+      "-Wno-unreachable-code-break",
+      "-Wno-unreachable-code",
+    ]
     if (is_win) {
-      cflags_c = [
+      cflags_c += [
         "-Wno-sign-compare",
         "-Wno-unused-but-set-variable",
         "-Wno-unused-function",