Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

romeo_112.yml: PLOS policy additions #14

Merged
merged 3 commits into from
May 10, 2018
Merged

romeo_112.yml: PLOS policy additions #14

merged 3 commits into from
May 10, 2018

Conversation

dhimmel
Copy link
Member

@dhimmel dhimmel commented May 10, 2018 •
edited
Loading

Supersedes #11
Closes #11

@dhimmel dhimmel mentioned this pull request May 10, 2018
Closed
@dhimmel
Copy link
Member Author

dhimmel commented May 10, 2018

https://travis-ci.com/transpose-publishing/policies-database/builds/73049627#L749 is failing due to the bool issue:

core.py                    164 ERROR    ["Value 'yes' is not of type 'bool'. Path: '/separate-structure'", "Value 'yes' is not of type 'bool'. Path: '/co-review-field'"]

dhimmel
dhimmel commented May 10, 2018
View reviewed changes
Copy link
Member Author

@dhimmel dhimmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpolka after the test passes (which I think it will), you can merge this PR. Here is a great opportunity to try out squash merge, since there are three commits, but they would be cleaner as one squashed commit.

@jpolka jpolka merged commit abfad27 into transpose-publishing:master May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhimmel @jpolka