-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ariels' version of: Upgrade version of oapi-codegen
#7532
base: master
Are you sure you want to change the base?
Commits on Apr 10, 2024
-
Upgrade version of
oapi-codegen
To get the latest features and bug fixes, we should bump to the latest version of the library.
Configuration menu - View commit details
-
Copy full SHA for 52500f8 - Browse repository at this point
Copy the full SHA 52500f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 660e4aa - Browse repository at this point
Copy the full SHA 660e4aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bc0208 - Browse repository at this point
Copy the full SHA 9bc0208View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d0b4e6 - Browse repository at this point
Copy the full SHA 5d0b4e6View commit details -
Use the [new names from 0.61.0](https://github.com/getkin/kin-openapi/blob/7aa9f7ee3d530160cd6479d28578a40b290d008f/README.md?plain=1#L325-L326).
Configuration menu - View commit details
-
Copy full SHA for cefbf58 - Browse repository at this point
Copy the full SHA cefbf58View commit details -
Modify types to match new OpenAPI generated code
Still does not compile: generated type of AbortPresignMultipartUpload method changed, and it is not clear where to get the body! ```compilation pkg/api/serve.go:59:35: cannot use controller (variable of type *Controller) as apigen.ServerInterface value in argument to apigen.HandlerFromMuxWithBaseURL: *Controller does not implement apigen.ServerInterface (wrong type for method AbortPresignMultipartUpload) have AbortPresignMultipartUpload("net/http".ResponseWriter, *"net/http".Request, apigen.AbortPresignMultipartUpload, string, string, string, apigen.AbortPresignMultipartUploadParams) want AbortPresignMultipartUpload("net/http".ResponseWriter, *"net/http".Request, string, string, string, apigen.AbortPresignMultipartUploadParams) ```
Configuration menu - View commit details
-
Copy full SHA for 365d909 - Browse repository at this point
Copy the full SHA 365d909View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc1e8f7 - Browse repository at this point
Copy the full SHA dc1e8f7View commit details -
The new Kin generator actually enforces examples are correct. This is a Good Thing.
Configuration menu - View commit details
-
Copy full SHA for 7c420f4 - Browse repository at this point
Copy the full SHA 7c420f4View commit details -
Fix middleware and some changes to accessing the changed Go APIs
Includes 7e0c91c, thanks @Jonathan-Rosenberg!
Configuration menu - View commit details
-
Copy full SHA for b143e55 - Browse repository at this point
Copy the full SHA b143e55View commit details -
Allow pagination prefix, after params to be empty strings
Apparently Kin now enforces even more OpenAPI rules.
Configuration menu - View commit details
-
Copy full SHA for a885553 - Browse repository at this point
Copy the full SHA a885553View commit details
Commits on Apr 11, 2024
-
Fix types to match generated code
The new generated code no longer aliases some types. This manifests primarily in all pagination parameters, which are now actual strings and ints.
Configuration menu - View commit details
-
Copy full SHA for 1496122 - Browse repository at this point
Copy the full SHA 1496122View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ebd118 - Browse repository at this point
Copy the full SHA 9ebd118View commit details