Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ariels' version of: Upgrade version of oapi-codegen #7532

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Commits on Apr 10, 2024

  1. Upgrade version of oapi-codegen

    To get the latest features and bug fixes, we should bump to the latest
    version of the library.
    jamietanna authored and arielshaqed committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    52500f8 View commit details
    Browse the repository at this point in the history
  2. go get github.com/oapi-codegen/v2/runtime

    Still doesn't compile.
    arielshaqed committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    660e4aa View commit details
    Browse the repository at this point in the history
  3. go mod tidy

    arielshaqed committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    9bc0208 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5d0b4e6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cefbf58 View commit details
    Browse the repository at this point in the history
  6. Modify types to match new OpenAPI generated code

    Still does not compile: generated type of AbortPresignMultipartUpload method
    changed, and it is not clear where to get the body!
    
    ```compilation
    pkg/api/serve.go:59:35: cannot use controller (variable of type *Controller) as apigen.ServerInterface value in argument to apigen.HandlerFromMuxWithBaseURL: *Controller does not implement apigen.ServerInterface (wrong type for method AbortPresignMultipartUpload)
    		have AbortPresignMultipartUpload("net/http".ResponseWriter, *"net/http".Request, apigen.AbortPresignMultipartUpload, string, string, string, apigen.AbortPresignMultipartUploadParams)
    		want AbortPresignMultipartUpload("net/http".ResponseWriter, *"net/http".Request, string, string, string, apigen.AbortPresignMultipartUploadParams)
    ```
    arielshaqed committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    365d909 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    dc1e8f7 View commit details
    Browse the repository at this point in the history
  8. Fix Swagger examples

    The new Kin generator actually enforces examples are correct.  This is a
    Good Thing.
    arielshaqed committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    7c420f4 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b143e55 View commit details
    Browse the repository at this point in the history
  10. Allow pagination prefix, after params to be empty strings

    Apparently Kin now enforces even more OpenAPI rules.
    arielshaqed committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    a885553 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Fix types to match generated code

    The new generated code no longer aliases some types.  This manifests
    primarily in all pagination parameters, which are now actual strings and
    ints.
    arielshaqed committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    1496122 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9ebd118 View commit details
    Browse the repository at this point in the history