added storage namespace validation on non-readonly bare repo creation

[tkalir]

Closes #3165

Background

Currently bare repo creation doesn't check if namesapce storage is writable \ if a lakefs repo already exists there

Bug Fix

In Controller.go\CreateRepository, previously the code was -

1. if bare repo, create and return
2. if non-readonly repo, do namespace validation
   I only switched them places, so namespace validation happens also for non-readonly bare repos. nothing else is supposed to change. (but that does mean that bare repos create a dummy object at namespace root now, like other repos - see Controller.go\ensureStorageNamespace)

Testing Details

I added a system test to check that creating a bare repo in same namespace as existing repo returns an error. we can remove the test if it's unnecessary, but it will help to check the code.

Contact Details

[email protected] \ Tamar Kalir on slack

[N-o-Z]

Hi @tkalir great job!

Though this is a small PR I'm requesting changes for the test as this is your first PR and I think this can be a good learning experience going into the lakeFS code.

[N-o-Z]

That's a great test - but note you could have reused the code of "use same storage namespace twice" and parameterize the test.
Look at the example of catalog_test.go:564 as reference