8158 bug UI not using presign for uploading objects #8365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItamarYuran
added
the
exclude-changelog
|
🎊 PR Preview 4f7f211 has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-8365.surge.sh 🕐 Build time: 0.013s
🤖 By surge-preview |
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8158
Change Description
With the added changes, it is now possible to upload a file from the UI, with a minimal IAM permissions installation.
Background
See #8158
Bug Fix
Root cause - the GET request for the presigned url did not include a checksum of the desired file.
Solution - Adding the checksum parameter to the api for getPhysicalAddress operation
Additional info
In order to upload a file to a presigned url, there is a need to configure the bucket's CORS.