Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 budget assertions seem wrong #13

Closed
shortcircuit3 opened this issue Nov 13, 2019 · 2 comments
Closed

v2 budget assertions seem wrong #13

shortcircuit3 opened this issue Nov 13, 2019 · 2 comments

Comments

@shortcircuit3
Copy link

One more thing...

I just tested with the NPM module and I have set my budgets correctly:

image

The 1KB over budged is expected. Using this action All my budgets are failing and I dont know what scale the numbers are in

image

@denar90
Copy link
Collaborator

denar90 commented Nov 16, 2019

Hey @milesalex.
First of all, sorry for the delay and thank you for pointing out the issue.

So, actually there are 2 problems:

  1. Assertion for resource-summary compared Kilobytes (values set via budget config) and Bytes (values measured from the site). It's fixed now in LHCI and after release will be fixed in Action.
  2. What you will still see - numbers without actual unit symbol. It has to be handled by User experience for showing failed assertions  GoogleChrome/lighthouse-ci#100. But for now, values you see in console are bytes.

@alekseykulikov
Copy link
Member

Fixed by the recent release, see the recipe for more details: https://github.com/treosh/lighthouse-ci-action/actions?query=workflow%3ALHCI-assert-on-budget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants