-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 budget assertions seem wrong #13
Comments
This was referenced Nov 16, 2019
Hey @milesalex. So, actually there are 2 problems:
|
Fixed by the recent release, see the recipe for more details: https://github.com/treosh/lighthouse-ci-action/actions?query=workflow%3ALHCI-assert-on-budget |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One more thing...
I just tested with the NPM module and I have set my budgets correctly:
The 1KB over budged is expected. Using this action All my budgets are failing and I dont know what scale the numbers are in
The text was updated successfully, but these errors were encountered: