Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent importing incompatible XPUB #11029

Closed
matejkriz opened this issue Feb 5, 2024 · 2 comments · Fixed by #11329
Closed

Prevent importing incompatible XPUB #11029

matejkriz opened this issue Feb 5, 2024 · 2 comments · Fixed by #11329
Assignees
@juriczech
Labels
mobile Suite Lite issues and PRs

Comments

@matejkriz
Copy link
Member

matejkriz commented Feb 5, 2024 •
edited by sime
Loading

  • Prevent importing testnet XPUB as Bitcoin mainnet account.

  • Prevent importing XPUB for a wrong coin when possible (dodge vs btc).

  • keep it simple

Check https://github.com/satoshilabs/slips/blob/master/slip-0132.md
Screenshot 2024-02-05 at 07 08 56

Design: use what we have for other cases - error message on submit.
Image
@matejkriz matejkriz converted this from a draft issue Feb 5, 2024
@matejkriz matejkriz added the mobile Suite Lite issues and PRs label Feb 5, 2024
@matejkriz matejkriz removed this from Suite Desktop Feb 5, 2024
@matejkriz matejkriz changed the title Warn when importing incompatible XPUB Prevent importing incompatible XPUB Feb 5, 2024
@juriczech juriczech self-assigned this Feb 22, 2024
@juriczech juriczech moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Mobile Feb 22, 2024
@juriczech juriczech mentioned this issue Feb 26, 2024
Merged
@juriczech
Copy link
Contributor

For @trezor/qa - Only available for bitcoin. When testing, test that bitcoin testnet xpub cannot be imported as BTC, all other coins should work same as previously.

@juriczech juriczech moved this from 🏃‍♀️ In progress to 🔎 Needs review in Suite Mobile Feb 26, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Suite Mobile Feb 26, 2024
@bosomt
Copy link
Contributor

bosomt commented Mar 4, 2024

Tested TEST > BTC QA OK
Tested BTC > TEST and it was imported

This ZPUB
https://btc1.trezor.io/xpub/zpub6rc2MkTC2EPUy8kHDGpk6NKpTmpdyVo43kiJi4aK2A1ePZpHpVKdYeyuUUUNKvjnBdc488mRPFGeoJTxepcW5kxxHwBhDAhTkZojr9WudhY?secondary=USD&use_secondary=true

Tested on 23.3.1 and 23.4.0
If its ok please approve @juriczech

@juriczech juriczech moved this from 🤝 Needs QA to ✅ Approved in Suite Mobile Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juriczech juriczech

Labels
mobile Suite Lite issues and PRs
Projects
Suite Mobile
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(suite-native): testnet cannot be imported as bitcoin account trezor/trezor-suite
3 participants
@matejkriz @bosomt @juriczech