Align query cancellation with JDBC driver #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashhar
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Thanks for catching this. This also simplifies things a bit.
For reference of future readers see DELETE on https://trino.io/docs/current/develop/client-protocol.html#http-methods.
|
I'd just reword commit to say "Fix query cancellation to correctly follow the protocol" since the client indeed didn't follow the documented protocol. |
damian3031
approved these changes
Jan 20, 2023
hovaesco
approved these changes
Jan 20, 2023
|
It addresses #289 |
mdesmet
force-pushed
the
bug/align-cancellation-with-jdbc-driver
branch
from
e1c293f to
6a9ea9c
Compare
|
@hashhar : PTAL |
This was referenced Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Align query cancellation with JDBC driver
Non-technical explanation
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: