-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for changing Iceberg table properties #11190
Comments
This is very useful, thanks! |
From Trino Iceberg table properties (IcebergTableProperties) perspective, we want to allow changing of |
@findepi thanks for the detail! There was another #10480 (comment) which seems to be looking for setting new properties to the icebergTable (pass-through) @findinpath If I understood correctly, this issue was to allow the random properties can be set to the underlying iceberg table as pass-through only? |
Same as in Hive -- i.e. to be figured out; #954 (comment) |
@findepi @findinpath I was looking for a good first issue but don't have any background in Iceberg. It also looks like there are things that have to be figured out here. Is it still a good first issue that I can take up? For some background on this if you guys have any recommendations I'd be happy to go through them first! |
I'm removing the |
Makes sense, thanks! |
@findepi is it ok to take the approach of adding I believe we are waiting for final decision on this hive's PR #9475 as well? do we need to take more blessings to go ahead, please guide, thanks. @Aashishthakur10, Sorry missed your comment. Actually, I was working on it, but as @findinpath mentioned it was not clear, so didnt make any progress. we also discussed in this thread: https://trinodb.slack.com/archives/CJ6UC075E/p1645767604315919?thread_ts=1645621806.119119&cid=CJ6UC075E |
No worries @osscm, that makes sense. Thanks for letting me know! |
@findinpath let's close this ticket, it's too generic. |
The implementation details for #12138 would fit then the #11190 (comment) comment. @findepi I'm fine with closing this ticket. However there seems to be an actual need for being able to set arbitrary table properties in Hive / Iceberg / Delta? via Trino. Should we continue the discussion on #954 ? |
Could you please clarify why did you close this ticket? I understand that there is a |
@C-h-e-r-r-y pls follow the issue #17427 |
Syntax for changing Iceberg table properties
Implementation tips
Implement the method
io.trino.spi.connector.ConnectorMetadata#setTableProperties
inio.trino.plugin.iceberg.IcebergMetadata
.Use
org.apache.iceberg.BaseTable#updateProperties
for updating table properties.Test tips
Add a integration test in
io.trino.plugin.iceberg.BaseIcebergConnectorTest
for testing the functionality. Use https://trino.io/docs/current/connector/iceberg.html#properties-table for reading the properties of the Iceberg table.Add a product test to the class
io.trino.tests.product.iceberg.TestIcebergSparkCompatibility
for checking the compatibility with Spark on updating table properties.The text was updated successfully, but these errors were encountered: