-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
passing extra credential #14364
Comments
The extra credentials are consumed by the server where it accepts the query submission. Perhaps it could be useful to document such things on https://trino.io/docs/current/develop/client-protocol.html, what do you think @djsstarburst ? |
Yes, that makes sense. I'll add it to my list. |
We should fix the sending of extra credential on every request in other clients as well since it seems unnecessary and adds confusion like shown here (since server won't do anything with it) - cc: @nineinchnick @hovaesco |
@hashhar do you know which clients are to be fixed? |
i guess this says Go and Python clients are affected. if so, let's have specific issues in these projects |
trino-cli
hasextra-credential
option. andgo-client
,python-client
also have that.but
trino-cli
has one different fromgo-client
,python-client
.trino-cli
only haveextra-credential
header when build query request.so
trino-cli
does not work when i useextra-credential
to passing sts token. but others is okay. because token is to be set in header every request.i suggest
trino-cli
extra-credential
option to be set every request not only build query request.The text was updated successfully, but these errors were encountered: