Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing extra credential #14364

Closed
twokindswater opened this issue Sep 29, 2022 · 5 comments
Closed

passing extra credential #14364

twokindswater opened this issue Sep 29, 2022 · 5 comments

Comments

@twokindswater
Copy link

trino-cli has extra-credential option. and go-client, python-client also have that.
but trino-cli has one different from go-client, python-client. trino-cli only have extra-credential header when build query request.
so trino-cli does not work when i use extra-credential to passing sts token. but others is okay. because token is to be set in header every request.

i suggest trino-cli extra-credential option to be set every request not only build query request.

@findepi
Copy link
Member

findepi commented Sep 29, 2022

The extra credentials are consumed by the server where it accepts the query submission.
They are not used after that, e.g. not used when polling for query results.

Perhaps it could be useful to document such things on https://trino.io/docs/current/develop/client-protocol.html, what do you think @djsstarburst ?

@djsstarburst
Copy link
Member

Perhaps it could be useful to document such things on https://trino.io/docs/current/develop/client-protocol.html

Yes, that makes sense. I'll add it to my list.

@findepi findepi closed this as completed Sep 29, 2022
@hashhar
Copy link
Member

hashhar commented Sep 30, 2022

We should fix the sending of extra credential on every request in other clients as well since it seems unnecessary and adds confusion like shown here (since server won't do anything with it) - cc: @nineinchnick @hovaesco

@findepi
Copy link
Member

findepi commented Sep 30, 2022

@hashhar do you know which clients are to be fixed?

@findepi
Copy link
Member

findepi commented Sep 30, 2022

i guess this says Go and Python clients are affected. if so, let's have specific issues in these projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants