Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding timestamp_ntz column should add reader and writer features #24158

Open
ebyhr opened this issue Nov 18, 2024 · 0 comments
Open

Adding timestamp_ntz column should add reader and writer features #24158

ebyhr opened this issue Nov 18, 2024 · 0 comments
Labels
delta-lake Delta Lake connector

Comments

@ebyhr
Copy link
Member

ebyhr commented Nov 18, 2024

Trino:

CREATE TABLE test (a int) WITH (change_data_feed_enabled = true);
TABLE "test$properties";
             key             | value
-----------------------------+-------
 delta.enableChangeDataFeed  | true
 delta.enableDeletionVectors | false
 delta.minReaderVersion      | 1
 delta.minWriterVersion      | 4
(4 rows)

-- This ADD COLUMN should add delta.feature.changeDataFeed = supported
ALTER TABLE test ADD COLUMN b timestamp;
TABLE "test$properties";
             key             |   value
-----------------------------+-----------
 delta.enableDeletionVectors | false
 delta.enableChangeDataFeed  | true
 delta.minReaderVersion      | 3
 delta.minWriterVersion      | 7
 delta.feature.timestampNtz  | supported

Spark:

CREATE TABLE test (a int) USING delta TBLPROPERTIES (delta.enableChangeDataFeed = true) LOCATION 's3://test-bucket/test';
SHOW TBLPROPERTIES test;
delta.enableChangeDataFeed	true
delta.minReaderVersion	1
delta.minWriterVersion	4

-- SET TBLPROPERTIES is required before adding timestamp_ntz column
ALTER TABLE test SET TBLPROPERTIES ('delta.feature.timestampNtz' = 'supported');
ALTER TABLE test ADD COLUMN b timestamp_ntz;
delta.enableChangeDataFeed	true
delta.feature.appendOnly	supported
delta.feature.changeDataFeed	supported
delta.feature.checkConstraints	supported
delta.feature.generatedColumns	supported
delta.feature.invariants	supported
delta.feature.timestampNtz	supported
delta.minReaderVersion	3
delta.minWriterVersion	7
@ebyhr ebyhr added the delta-lake Delta Lake connector label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delta-lake Delta Lake connector
Development

No branches or pull requests

1 participant