Add support to add and show (create table) extra hive table properties

[ankitdixit]

Fixes #954

Need help in ShowQueriesRewrite, please help me converting a map to an expression

[ankitdixit]

#954

[ankitdixit]

Working on adding and showing properties via showCreateTable, will add merge validation post that

[dain]

Oops, I reviewed this like a week ago and forgot to post the answer to the above question. Sorry.

When this is ready for a final review, remove the WIP label and assign it back to me.

[findepi]

@ankitdixit can you please update & rebase?

this relates to #3583
cc @larandvit

[ankitdixit]

@ankitdixit can you please update & rebase?

this relates to #3583
cc @larandvit

I somehow missed this. updating now

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ankit Dixit.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ankit Dixit.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[aakashnand]

@ankitdixit Is this only for hive connector or we can add these properties to any table? I understand that currently TBLPROPERTIES is only supported in hive but can we extend this to all connectors?

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ankit Dixit.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[ankitdixit]

After this change, every show create table seems to have an extra line and a few tests are failing like:
java.lang.AssertionError: expected [CREATE TABLE hive.tpch.test_comment_table ( c1 bigint ) WITH ( format = 'RCBINARY' )] but found [CREATE TABLE hive.tpch.test_comment_table ( c1 bigint ) WITH ( extra_properties = map_from_entries(ARRAY[]), format = 'RCBINARY' )]
Should I change the tests or is there a way to not show extra properties line when they are empty

[findepi]

@ankitdixit we should avoid changes in the SHOW CREATE TABLE.
Did you try making extra_properties default to NULL instead?

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Ankit Dixit.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[colebow]

👋 @ankitdixit - this PR is inactive and doesn't seem to be under development, and it might already be implemented. If you'd like to continue work on this at any point in the future, feel free to re-open.