Add support for creating view with properties in engine and hive #21401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
force-pushed
the
praveen/create_view_with_properties
branch
from
b2df1a5 to
abae4ae
Compare
Praveen2112
force-pushed
the
praveen/create_view_with_properties
branch
4 times, most recently
from
e6b10f0 to
bf1e26c
Compare
Praveen2112
requested review from
findepi,
ebyhr,
findinpath,
martint,
krvikash and
marcinsbd
findepi
approved these changes
Apr 8, 2024
core/trino-main/src/main/java/io/trino/execution/CreateViewTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/connector/MockConnector.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorMetadata.java
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java
Outdated
Show resolved
Hide resolved
Use PlannerContext to get metadata instead of injecting it directly.
Praveen2112
force-pushed
the
praveen/create_view_with_properties
branch
from
bf1e26c to
31a0760
Compare
|
@findepi Thanks for the review. AC |
Praveen2112
force-pushed
the
praveen/create_view_with_properties
branch
from
31a0760 to
e0b394c
Compare
marcinsbd
reviewed
Apr 10, 2024
Praveen2112
force-pushed
the
praveen/create_view_with_properties
branch
from
e0b394c to
de2eed1
Compare
|
@marcinsbd AC |
marcinsbd
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for
CREATE VIEW WITH PROPERTIESin engine and in Hive connector. In case of hive we are introducing a new propertyextra_propertywhich would allow us to add arbitrary property to hive as `Map<String, String>.This PR doesn't have docs and it will be handled as dedicated task which is mentioned as a part of this ticket - #20992
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: