[WIP] Arbitrary table properties

[dain]

Add support for arbitrary table properties in Hive connector.

trino:tpch> create table example (id bigint) with (extra_property_food = 'taco');
CREATE TABLE
trino:tpch> show create table example;
           Create Table           
----------------------------------
 CREATE TABLE hive.tpch.example ( 
    id bigint                     
 )                                
 WITH (                           
    extra_property_food = 'taco', 
    format = 'ORC'                
 )                                
(1 row)

This PR will need:

• review of SPI changes
• review of naming convention in Hive
• better error handling in Hive changes
• maybe better prevention of aliasing known Hive properties
• a review of unmanaged Hive properties for security issues
• a flag to diisable extra properties
• tests
• documentation

Resolves #955
Alternative to #9475

[dain]

After further thought, I'm not sure we need to implement Hive extra properties this way. The alternative implementation #9475 used a single map to contain all of the properties. The concern I had was that was how we would update a map like that. You would have to read the map, modify it and post it back, but that could result in losing or restoring properties changed during the update. What I didn't realize is we have no commands in Trino to modify a table property. We could use the simpler map style properties in #9475, and then when we add the syntax for setting a table property, we make it:

ALTER TABLE table_name SET  PROPERTY property_name[.field_name]*

I think this might be a better approach.

cc @martint and @electrum

[findepi]

extra_property_food = 'taco',

this is not the way to go. BTW we already discussed the syntax and decided to go with catch-all map in Hive connector only.

this new approach has two problems

• requires name mangling for property names that are not valid Trino property names; without mangling, hive dotted convention cannot be used
• leaves user with the impression that anything works, and every property is supported by Trino. Sub-ideal UX, but also more questions to answer ("i set this property, why did Trino do this")

[mosabua]

👋 @dain and @findepi .. from the discussion in this PR I conclude that we can close this. Correct?

[lmove]

Hi! Our tool BreakBot found that this pull request introduces 2 breaking changes and deprecations and they appear to impact 4 of your clients. You can find the full BreakBot report in our fork repository: report for PR#9523.

We hope this information is valuable to you, and apologize otherwise. If you're willing to help, we would kindly ask for your help to fill in a 5-minutes survey about the report. Your feedback will help us improve the tool and provide a better experience for users in the future!