From 67bdb35e0f3de9055c357c72072fa3892d164a70 Mon Sep 17 00:00:00 2001 From: Ujjwal Sharma Date: Tue, 6 Mar 2018 19:39:10 +0530 Subject: [PATCH] test: rename test-regress-GH-784.js Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: https://github.com/nodejs/node/issues/19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: https://github.com/nodejs/node/pull/19161 Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater Reviewed-By: Joyee Cheung Reviewed-By: Richard Lau Reviewed-By: Gireesh Punathil --- ...est-regress-GH-784.js => test-http-econnrefused.js} | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) rename test/sequential/{test-regress-GH-784.js => test-http-econnrefused.js} (96%) diff --git a/test/sequential/test-regress-GH-784.js b/test/sequential/test-http-econnrefused.js similarity index 96% rename from test/sequential/test-regress-GH-784.js rename to test/sequential/test-http-econnrefused.js index 4b285020d45a35..ff4508963b9877 100644 --- a/test/sequential/test-regress-GH-784.js +++ b/test/sequential/test-http-econnrefused.js @@ -20,15 +20,15 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. 'use strict'; -// Regression test for GH-784 -// https://github.com/joyent/node/issues/784 -// +const common = require('../common'); + // The test works by making a total of 8 requests to the server. The first // two are made with the server off - they should come back as ECONNREFUSED. // The next two are made with server on - they should come back successful. // The next two are made with the server off - and so on. Without the fix -// we were experiencing parse errors and instead of ECONNREFUSED. -const common = require('../common'); +// we were experiencing parse errors instead of ECONNREFUSED. +// https://github.com/nodejs/node-v0.x-archive/issues/784 + const http = require('http'); const assert = require('assert');