Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tsconfig): set removeComments to true #8

Closed
wants to merge 1 commit into from
Closed

chore(tsconfig): set removeComments to true #8

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Owner

@trivikr trivikr commented Sep 17, 2021 •
edited
Loading

Description of changes:
Experiment with tsconfig removeComments

We're not going ahead with this change, as TypeScript removes comments even from *.d.ts files.
We need comments in *.d.ts files, as they're used as an API Reference while coding - like in Intellisense.

Open feature request in TypeScript repo microsoft/TypeScript#14619

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr
Copy link
Owner Author

trivikr commented Sep 17, 2021

Size difference for reference:

With comments 
package size:  616.3 kB
unpacked size: 7.1 MB
total files:   670
Without comments 
package size:  285.5 kB                                
unpacked size: 4.2 MB                                  
total files:   670

@trivikr trivikr closed this Sep 17, 2021
@trivikr trivikr deleted the removeComments branch September 17, 2021 04:24
@trivikr trivikr mentioned this pull request Sep 17, 2021
Merged
@trivikr
Copy link
Owner Author

trivikr commented Oct 12, 2021

Superceded by #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trivikr