Memory leak if realloc() fails

[l2dy]

If realloc() fails, it returns NULL and the original block of memory is left untouched; it is not freed or moved.

In our case, we lost the reference to the original block of memory and it is not freed, causing a memory leak. This happens if there is an error, for example when the host is out of memory.

mini-snmpd/mib.c

Lines 104 to 106 in 45765e3

	data->buffer = realloc(data->buffer, data->max_length);
	if (!data->buffer)
	return 2;

If this happens, it is recommended to free the original block of memory, or keep data->buffer unchanged.