This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
feat: get Filecoin.ClientRetrieve to actually save a file and update IPFS #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeseese
force-pushed
the
feat/filecoin-clientretrieve
branch
3 times, most recently
from
182402c to
f170c08
Compare
mikeseese
force-pushed
the
feat/filecoin-clientretrieve
branch
from
f170c08 to
c502fd3
Compare
davidmurdoch
suggested changes
Feb 22, 2021
davidmurdoch
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Probably still need @tcoulter's Approval, as I haven't checked the Filecoin-specific bits whatsoever :-)
tcoulter
approved these changes
Mar 4, 2021
akhilmantha
pushed a commit
to akhilmantha/testrpc
that referenced
this pull request
Apr 27, 2022
## [6.11.1-alpha.1](trufflesuite/ganache@v6.11.0...v6.11.1-alpha.1) (2020-10-01) ### Bug Fixes * install ganache-core v2.13.0-alpha.2 ([2df40c0](trufflesuite/ganache@2df40c0)) * remove unneeded COPY command from docker build ([trufflesuite#790](trufflesuite/ganache#790)) ([31e6cf0](trufflesuite/ganache@31e6cf0)) * update ganache-core to v2.12.2-beta.0 to fix Node v14 compat ([trufflesuite#791](trufflesuite/ganache#791)) ([c3adce9](trufflesuite/ganache@c3adce9))
akhilmantha
pushed a commit
to akhilmantha/testrpc
that referenced
this pull request
Apr 27, 2022
## [6.11.1-alpha.1](trufflesuite/ganache@v6.11.0...v6.11.1-alpha.1) (2020-10-02) ### Bug Fixes * install ganache-core v2.13.0-alpha.2 ([2df40c0](trufflesuite/ganache@2df40c0)) * remove unneeded COPY command from docker build ([trufflesuite#790](trufflesuite/ganache#790)) ([31e6cf0](trufflesuite/ganache@31e6cf0)) * update ganache-core to v2.12.2-beta.0 to fix Node v14 compat ([trufflesuite#791](trufflesuite/ganache#791)) ([c3adce9](trufflesuite/ganache@c3adce9))
akhilmantha
pushed a commit
to akhilmantha/testrpc
that referenced
this pull request
Apr 27, 2022
## [6.11.1-beta.1](trufflesuite/ganache@v6.11.0...v6.11.1-beta.1) (2020-10-06) ### Bug Fixes * install ganache-core v2.13.0-alpha.2 ([2df40c0](trufflesuite/ganache@2df40c0)) * remove unneeded COPY command from docker build ([trufflesuite#790](trufflesuite/ganache#790)) ([31e6cf0](trufflesuite/ganache@31e6cf0)) * update ganache-core to v2.12.2-beta.0 to fix Node v14 compat ([trufflesuite#791](trufflesuite/ganache#791)) ([c3adce9](trufflesuite/ganache@c3adce9)) * update ganache-core to v2.13.0-beta.0 ([2de7bdd](trufflesuite/ganache@2de7bdd))
akhilmantha
pushed a commit
to akhilmantha/testrpc
that referenced
this pull request
Apr 27, 2022
# [6.12.0](trufflesuite/ganache@v6.11.0...v6.12.0) (2020-10-09) ### Bug Fixes * install ganache-core v2.13.0-alpha.2 ([2df40c0](trufflesuite/ganache@2df40c0)) * remove unneeded COPY command from docker build ([trufflesuite#790](trufflesuite/ganache#790)) ([31e6cf0](trufflesuite/ganache@31e6cf0)) * update ganache-core to v2.12.2-beta.0 to fix Node v14 compat ([trufflesuite#791](trufflesuite/ganache#791)) ([c3adce9](trufflesuite/ganache@c3adce9)) * update ganache-core to v2.13.0-beta.0 ([2de7bdd](trufflesuite/ganache@2de7bdd)) ### Features * update ganache-core to v2.13.0 ([1e7ad11](trufflesuite/ganache@1e7ad11))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #714 and #719 (I have included IPFS updating in this PR as it was a good combination to reduce the number of PRs while still making sure they're not too big). The main difference in this PR is further maturation, technical correctness, and make sure there are sufficient tests.
After uploading a file under
/marketin the network inspector example, there is an option (that is commented out in the example code) to download the file.Filecoin.ClientRetrieveis supposed to save the file to a location on disk provided by the user in therefargument. This PR adds the functionality of usingrefand saving the file to disk. This is an initial implementation and will likely need to be adjusted later as use cases expand.We also update IPFS to the latest version.
ipfs-http-serverdepends on the latest https://github.com/hapijs/hapi which usesnode@12+only features (private fields in JS). This means we can no longer run Filecoin tests onnode@10|11; this PR updates that as well.