Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Bad line number reports on test failure #287

Closed
elenadimitrova opened this issue Jan 25, 2019 · 3 comments
Closed

Bad line number reports on test failure #287

elenadimitrova opened this issue Jan 25, 2019 · 3 comments

Comments

@elenadimitrova
Copy link

Since upgrading ganache-core to version 2.3.2 back in mid December, we started experiencing incorrect reports by truffle test runs upon failures.

Expected Behavior

When a truffle test run fails, mocha reports the correct line number in test source where the failure occurred. Below are a set of sample failed builds quoting test line numbers that are correct:
https://circleci.com/gh/JoinColony/colonyNetwork/5051
https://circleci.com/gh/JoinColony/colonyNetwork/5287
https://circleci.com/gh/JoinColony/colonyNetwork/5493
https://circleci.com/gh/JoinColony/colonyNetwork/5505

Current Behavior

Incorrect line number is reported when a test fails.
Below are a set of sample failed builds quoting test line numbers that are INcorrect:
https://circleci.com/gh/JoinColony/colonyNetwork/5553
https://circleci.com/gh/JoinColony/colonyNetwork/5582
https://circleci.com/gh/JoinColony/colonyNetwork/5636
https://circleci.com/gh/JoinColony/colonyNetwork/5721

Possible Solution

Although not a solution, @area suspects this change might be the cause of our woes.

We did test with ganache-core v2.2.1 where this issue isn't present.

Context

Resolving any test failures has become rather laborious as you never know where in the test file the error comes from. This makes for some horrendous developer experience.

Your Environment

@davidmurdoch
Copy link
Member

@eggplantzzz thinks this may have been resolved on the Truffle side. We still need to investigate a bit more before closing.

@eggplantzzz
Copy link
Contributor

Can anyone confirm that this is still or is no longer an issue?

@davidmurdoch
Copy link
Member

Closing for issue maintenance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants