Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

idea: add in warning to help switch over to new "pending tx" mode #674

Closed
davidmurdoch opened this issue Dec 9, 2020 · 4 comments
Closed
Milestone

Comments

@davidmurdoch
Copy link
Member

If a transaction is submitted with a future nonce (not immediately executable), and no other requests coming for n seconds, we could log a helpful message that there is a pending transaction, and why it is pending.

We could also/instead, log useful information about each transaction, in a way that informs the user that the transaction will not be mined immediately because of its future nonce.

/cc @cds-amal

@davidmurdoch davidmurdoch added this to the 3.1.0 milestone Dec 9, 2020
@gnidan gnidan modified the milestones: 7.1.0, 7.0.0 Mar 31, 2021
@gnidan
Copy link
Contributor

gnidan commented Mar 31, 2021

@eggplantzzz graciously implemented this already.

@eggplantzzz
Copy link
Contributor

I'm actually not sure this was done, I implemented a warning when people are using the newer instamine feature and request a tx that is pending. There might be more that this ticket suggests be done.

@davidmurdoch davidmurdoch modified the milestones: 7.0.0, 7.1.0 Aug 11, 2021
@davidmurdoch
Copy link
Member Author

Discussed this with @eggplantzzz and @MicaiahReid and I think we should add this for 7.1.0, if at all. We could do it behind a new opt-in --hints flag, or by default behind an opt-out --no-hints flag.

@davidmurdoch davidmurdoch moved this to Inbox in Ganache Jul 19, 2022
@davidmurdoch davidmurdoch moved this from Inbox to Backlog in Ganache Jul 19, 2022
@MicaiahReid
Copy link
Contributor

Closing cause @davidmurdoch regrets opening it.

Repository owner moved this from Backlog to Done in Ganache Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

No branches or pull requests

4 participants