From 16eeda155723263876b72ba505a9a5573fc39cbb Mon Sep 17 00:00:00 2001 From: David Murdoch Date: Wed, 30 Sep 2020 13:58:46 -0400 Subject: [PATCH 1/5] test: increase infura test timeouts so they stop failling in CI --- test/smoke/forking/infura/simple.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/smoke/forking/infura/simple.js b/test/smoke/forking/infura/simple.js index 33e06891fe..cb02f44f9e 100644 --- a/test/smoke/forking/infura/simple.js +++ b/test/smoke/forking/infura/simple.js @@ -152,4 +152,4 @@ describe("Simple Infura", function() { await new Promise((resolve) => provider.close(resolve)); }); -}); +}).timeout(5000); From 7794dcf30a44c845c6f4d9280c70e5929a2a093d Mon Sep 17 00:00:00 2001 From: David Murdoch Date: Wed, 30 Sep 2020 14:23:22 -0400 Subject: [PATCH 2/5] change describe to use an arrow function --- test/smoke/forking/infura/simple.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/smoke/forking/infura/simple.js b/test/smoke/forking/infura/simple.js index cb02f44f9e..0e3f4a3c3a 100644 --- a/test/smoke/forking/infura/simple.js +++ b/test/smoke/forking/infura/simple.js @@ -10,7 +10,7 @@ const logger = { } }; -describe("Simple Infura", function() { +describe("Simple Infura", () => { let INFURA_KEY; before(function() { From 9b051bc7c0e8ead7bc0218cfbec35973a2edc524 Mon Sep 17 00:00:00 2001 From: David Murdoch Date: Wed, 30 Sep 2020 15:00:03 -0400 Subject: [PATCH 3/5] apply timeout to each test, as the describe method isn't working --- test/smoke/forking/infura/simple.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/test/smoke/forking/infura/simple.js b/test/smoke/forking/infura/simple.js index 0e3f4a3c3a..176228a310 100644 --- a/test/smoke/forking/infura/simple.js +++ b/test/smoke/forking/infura/simple.js @@ -41,7 +41,7 @@ describe("Simple Infura", () => { assert.strictEqual(block.transactions.length, numTransactions); await new Promise((resolve) => provider.close(resolve)); - }); + }).timeout(5000); it("forks mainnet wss", async function() { // https://etherscan.io/block/10661638 @@ -63,7 +63,7 @@ describe("Simple Infura", () => { assert.strictEqual(block.transactions.length, numTransactions); await new Promise((resolve) => provider.close(resolve)); - }); + }).timeout(5000); it("forks goerli https", async function() { // https://goerli.etherscan.io/block/3226587 @@ -85,7 +85,7 @@ describe("Simple Infura", () => { assert.strictEqual(block.transactions.length, numTransactions); await new Promise((resolve) => provider.close(resolve)); - }); + }).timeout(5000); it("forks ropsten https", async function() { // https://ropsten.etherscan.io/block/8500030 @@ -107,7 +107,7 @@ describe("Simple Infura", () => { assert.strictEqual(block.transactions.length, numTransactions); await new Promise((resolve) => provider.close(resolve)); - }); + }).timeout(5000); it("forks rinkeby https", async function() { // https://rinkeby.etherscan.io/block/7019987 @@ -129,7 +129,7 @@ describe("Simple Infura", () => { assert.strictEqual(block.transactions.length, numTransactions); await new Promise((resolve) => provider.close(resolve)); - }); + }).timeout(5000); it("forks kovan https", async function() { // https://kovan.etherscan.io/block/20255583 @@ -151,5 +151,5 @@ describe("Simple Infura", () => { assert.strictEqual(block.transactions.length, numTransactions); await new Promise((resolve) => provider.close(resolve)); - }); -}).timeout(5000); + }).timeout(5000); +}) From 4228158cfd9ff2baa47e6a0b315245fa4b23059b Mon Sep 17 00:00:00 2001 From: David Murdoch Date: Wed, 30 Sep 2020 15:03:04 -0400 Subject: [PATCH 4/5] add semicolon back in --- test/smoke/forking/infura/simple.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/smoke/forking/infura/simple.js b/test/smoke/forking/infura/simple.js index 176228a310..c77ffae43c 100644 --- a/test/smoke/forking/infura/simple.js +++ b/test/smoke/forking/infura/simple.js @@ -152,4 +152,4 @@ describe("Simple Infura", () => { await new Promise((resolve) => provider.close(resolve)); }).timeout(5000); -}) +}); From af24fb8514a0313c051de3cc3576ea42d690c904 Mon Sep 17 00:00:00 2001 From: David Murdoch Date: Wed, 30 Sep 2020 15:35:57 -0400 Subject: [PATCH 5/5] test: increase timeout on a test so it won't fail --- test/local/forking/snapshot.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/local/forking/snapshot.js b/test/local/forking/snapshot.js index 54d0da3b3c..78c3cdfb42 100644 --- a/test/local/forking/snapshot.js +++ b/test/local/forking/snapshot.js @@ -122,5 +122,5 @@ describe("Forking Snapshots", () => { value = await instance.methods.value().call(); assert.strictEqual(value, "2"); - }); + }).timeout(5000); });