Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trunk serve does not respect custom address #862

Open
joshvoigts opened this issue Sep 1, 2024 · 1 comment
Open

Trunk serve does not respect custom address #862

joshvoigts opened this issue Sep 1, 2024 · 1 comment

Comments

@joshvoigts
Copy link

joshvoigts commented Sep 1, 2024

System details

macos 14.6.1

Steps to reproduce

  1. Run trunk serve --address 0.0.0.0
  2. Observe that trunk runs on localhost instead:
2024-09-01T17:10:15.467034Z  INFO 🚀 Starting trunk 0.20.3
2024-09-01T17:10:15.473654Z  INFO 📦 starting build
2024-09-01T17:10:18.121126Z  INFO applying new distribution
2024-09-01T17:10:18.122946Z  INFO ✅ success
2024-09-01T17:10:18.123208Z  INFO 📡 serving static assets at -> /
2024-09-01T17:10:18.123247Z  INFO 📡 server listening at:
2024-09-01T17:10:18.123250Z  INFO     🏠 http://127.0.0.1:8080/

Relates to: #467

@ctron
Copy link
Collaborator

ctron commented Sep 2, 2024

I do recall some issues with older trunk versions. IIRC, it was only a displaying issue though. Running 0.21.0-rc.3 (on Fedora 40), I get:

➜  vanilla git:(main) trunk serve --address 0.0.0.0
2024-09-02T06:49:48.205970Z  INFO 🚀 Starting trunk 0.21.0-rc.3
2024-09-02T06:49:48.220263Z  INFO 📦 starting build
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.02s
2024-09-02T06:49:48.672576Z  INFO applying new distribution
2024-09-02T06:49:48.674531Z  INFO ✅ success
2024-09-02T06:49:48.674576Z  INFO 📡 serving static assets at -> /
2024-09-02T06:49:48.674867Z  INFO 📡 server listening at:
2024-09-02T06:49:48.674872Z  INFO     🏠 http://127.0.0.1:8080/
2024-09-02T06:49:48.674877Z  INFO     💻 http://192.168.122.1:8080/
2024-09-02T06:49:48.674880Z  INFO     💻 http://192.168.130.1:8080/
2024-09-02T06:49:48.674883Z  INFO     💻 http://192.168.188.92:8080/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants