Remove aws-lc-sys dependency #923
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I absolutely like the idea of bringing back a sane However, I think it would make sense to default trunk's build to just |
|
Glad to hear that you also think so! I figured I'd put the most critical tweak into this PR, and then open another PR that changes the default to be rustls without aws. As in, this should be ready to merge right away. |
|
I'd prefer to have a single PR and release this right away. I'd consider this an (un)breaking change :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that
cargo build --no-default-features -F update_check,rustlsworks as intended on Windows once again.Fix #920
It's possible for users to opt-in into aws-lc-sys by depending on
rustlsthemselves, and enabling the feature.